mike-jumper commented on issue #348: GUACAMOLE-422: Forward Timezone to RDP and SSH Connections URL: https://github.com/apache/guacamole-client/pull/348#issuecomment-478093195 Yes, that's correct. The semantics of `args` would need to be modified in a backward-compatible way. For example, if a simple protocol implementation would currently produce: 4.args,8.hostname,4.port; consider a change to `args` which would include the version number as one of the arguments: 4.args,5.1.1.0,8.hostname,4.port; If the definition of `args` from that point forward specified that the first argument is the version number, then code that's aware of this would be able to make decisions based on that number. Code that's unaware of this would continue with the old `args` semantics, considering "1.1.0" to be the name of a parameter. With no value defined for such a parameter, a conforming implementation would simply include the empty string in the `connect` response: 7.connect,0.,9.localhost,4.1234; whereas newer implementations would know to handle that value specifically. One possibility here would be to similarly modify `connect` to specify that the first argument should be the protocol version of the client (with the exception of older clients that may include an empty string): 7.connect,5.1.1.0,8.hostname,4.port; That version information could be logged, included in `guac_user`, compared against the guacd version, etc. Whether the version number should be the literal release version or some protocol-specific version number (or both?) is also worth considering.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
