mike-jumper commented on issue #348: GUACAMOLE-422: Forward Timezone to RDP and SSH Connections URL: https://github.com/apache/guacamole-client/pull/348#issuecomment-489673166 No, I think what you already have is better defined. On Mon, May 6, 2019, 08:54 Virtually Nick <[email protected]> wrote: > *@necouchman* commented on this pull request. > ------------------------------ > > In > guacamole-common/src/main/java/org/apache/guacamole/protocol/GuacamoleProtocolVersion.java > <https://github.com/apache/guacamole-client/pull/348#discussion_r281246386> > : > > > + return patch; > + } > + > + /** > + * Determines whether or not this object is greater than or equal to the > + * the version passed in to the method. Returns a boolean true if the > + * version is the same as or greater than the other version, otherwise > + * false. > + * > + * @param otherVersion > + * The version to which this object should be compared. > + * > + * @return > + * True if this object is greater than or equal to the other version. > + */ > + public boolean atLeast(GuacamoleProtocolVersion otherVersion) { > > It looks like Java enums implement the compareTo() method, though, using > the position of declaration of the enum value as the relative comparison > between them. So, I could leverage that, instead of a function like this, > but is that something we really want to rely on? > > — > You are receiving this because you commented. > Reply to this email directly, view it on GitHub > <https://github.com/apache/guacamole-client/pull/348#discussion_r281246386>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/ABDLCSKOUD5CP2G4BPTDPQDPUBIDDANCNFSM4GMCXWBQ> > . >
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
