necouchman commented on a change in pull request #348: GUACAMOLE-422: Forward
Timezone to RDP and SSH Connections
URL: https://github.com/apache/guacamole-client/pull/348#discussion_r281226422
##########
File path:
guacamole-common/src/main/java/org/apache/guacamole/protocol/ConfiguredGuacamoleSocket.java
##########
@@ -184,6 +199,20 @@ public ConfiguredGuacamoleSocket(GuacamoleSocket socket,
"image",
info.getImageMimetypes().toArray(new String[0])
));
+
+ // Protocol version 1.1.0 and higher options
+
+ if (protocol.atLeast(GuacamoleProtocolVersion.VERSION_1_1_0)) {
+ // Send client timezone, if available
+ String timezone = info.getTimezone();
+ if (timezone != null && !timezone.isEmpty()) {
Review comment:
Well, currently in the `GuacamoleClientInformation` class it is
pre-initialized to an empty string. I don't know if there was a particular
reason I did this - I think I was trying to follow the pattern of the other
config information, like the mimetypes, which are initialized to an empty list.
So, if anything, shouldn't it be only empty and skip the `null` check?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
