necouchman commented on a change in pull request #348: GUACAMOLE-422: Forward
Timezone to RDP and SSH Connections
URL: https://github.com/apache/guacamole-client/pull/348#discussion_r281248812
##########
File path:
guacamole-common/src/main/java/org/apache/guacamole/protocol/ConfiguredGuacamoleSocket.java
##########
@@ -142,6 +150,13 @@ public ConfiguredGuacamoleSocket(GuacamoleSocket socket,
// Retrieve argument name
String arg_name = arg_names.get(i);
+
+ // Check for protocol version as first argument
+ if (i == 0 && arg_name.startsWith("VERSION_")) {
+ protocol = GuacamoleProtocolVersion.valueOf(arg_name);
Review comment:
Okay, I implemented a `getVersion()` method that checks for null/empty and
then wraps `valueOf()` for the time being. I'm happy to do something different
in `getVersion()` if that's desirable, but at least it decouples from reliance
upon `valueOf()` at this point.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
