mike-jumper commented on a change in pull request #348: GUACAMOLE-422: Forward
Timezone to RDP and SSH Connections
URL: https://github.com/apache/guacamole-client/pull/348#discussion_r283111353
##########
File path:
guacamole-ext/src/main/resources/org/apache/guacamole/protocols/rdp.json
##########
@@ -195,6 +195,10 @@
{
"name" : "static-channels",
"type" : "TEXT"
+ },
+ {
+ "name" : "timezone",
+ "type" : "TIMEZONE"
Review comment:
I don't recall if this was mentioned before, but the `TIMEZONE` field type
uses the Java IDs for its values:
https://github.com/apache/guacamole-client/blob/e02dcf8c84f0f7f2f9c866b0258bde0551c847b9/guacamole/src/main/webapp/app/form/controllers/timeZoneFieldController.js#L21-L25
This won't match the IANA values required by the `timezone` parameters. The
recent changes from #403 use a `TEXT` field for this, however if you'd like to
provide convenient drop-downs, etc., a new field type could be defined that
uses the IANA values (`IANA_TIMEZONE`?)
Beware also that the #403 changes added this in a different section, so if
you feel that this should be in `device-redirection`, the other parameter
definition will need to be deleted.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
