mike-jumper commented on a change in pull request #348: GUACAMOLE-422: Forward
Timezone to RDP and SSH Connections
URL: https://github.com/apache/guacamole-client/pull/348#discussion_r283593553
##########
File path:
guacamole-ext/src/main/resources/org/apache/guacamole/protocols/rdp.json
##########
@@ -195,6 +195,10 @@
{
"name" : "static-channels",
"type" : "TEXT"
+ },
+ {
+ "name" : "timezone",
+ "type" : "TIMEZONE"
Review comment:
I did a quick search of all the time zones in my zoneinfo database on my
Linux system, and absolutely all time zones currently defined within the field
match **except one**: `Canada/East-Saskatchewan`.
This is apparently a rare case of a time zone identifier being removed from
the database:
https://stackoverflow.com/questions/47618861/error-invalid-value-for-parameter-timezone-canada-east-saskatchewan/47625517#47625517
So ... I think we are indeed safe, but should probably remove
`Canada/East-Saskatchewan`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
