mike-jumper commented on issue #253: GUACAMOLE-304: Expand connection link to encompass entire hover area. URL: https://github.com/apache/guacamole-client/pull/253#issuecomment-502814136 @manolan1 - this is a pull request which is closed, having been merged about a year ago, for an issue which has been resolved and released. If you have questions on these changes, please use the mailing list. > ... wouldn't it have been better to change it to inline-block? No. The issue that this PR addressed was the size of the link not actually matching the highlighted region, leading to confusion: https://issues.apache.org/jira/browse/GUACAMOLE-304 `inline-block` would not have produced the same behavior as `block` in that respect. > I ask because it broke one of my extensions ... If you would like to propose a change, feel free to open a new JIRA issue and pull request with those changes. If there is a better way to achieve this which also has a lower potential of breaking third-party styling, I see no reason why that would not be merged. Be sure to describe what specifically broke.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
