mike-jumper commented on issue #345: GUACAMOLE-234: Migrate to Apache Directory API for LDAP Extension URL: https://github.com/apache/guacamole-client/pull/345#issuecomment-502880455 @necouchman - I just looked over things quickly and things look fine at first glance. I'll do a more thorough review in a bit, but I think this is probably ready to move forward. There is a merge conflict noted by GitHub for `ConnectionService.java` which will need to be resolved. Earlier comments noted warnings being repeatedly logged by parts of the Apache Directory API: > ``` > ... > 11:26:19.232 [NioProcessor-1] WARN o.a.d.a.l.m.entry.DefaultAttribute - ERR_13207_VALUE_ALREADY_EXISTS The value 'CN=DC1,OU=Sunday,OU=Domain Controllers,DC=example,DC=local' already exists in the attribute (msDS-RevealedDSAs) > 11:26:19.233 [NioProcessor-1] WARN o.a.d.a.l.m.entry.DefaultAttribute - ERR_13207_VALUE_ALREADY_EXISTS The value 'CN=DC1,OU=Sunday,OU=Domain Controllers,DC=example,DC=local' already exists in the attribute (msDS-RevealedDSAs) > 11:26:19.233 [NioProcessor-1] WARN o.a.d.a.l.m.entry.DefaultAttribute - ERR_13207_VALUE_ALREADY_EXISTS The value 'CN=DC1,OU=Sunday,OU=Domain Controllers,DC=example,DC=local' already exists in the attribute (msDS-RevealedDSAs) > ... > ``` Anyone know whether this happens as frequently as it looks here (or what needs to be fixed to remove these warnings)? Will Guacamole logs be filled with LDAP warnings following merge?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
