mike-jumper commented on a change in pull request #303: GUACAMOLE-579: Get user
attributes from CAS ticket
URL: https://github.com/apache/guacamole-client/pull/303#discussion_r296068488
##########
File path:
guacamole-ext/src/main/java/org/apache/guacamole/token/TokenName.java
##########
@@ -63,35 +57,38 @@
/**
* This utility class should not be instantiated.
*/
- private TokenName() {}
+ protected TokenName() {}
/**
* Generates the name of the parameter token that should be populated with
- * the value of the given LDAP attribute. The name of the LDAP attribute
- * will automatically be transformed from "CamelCase", "headlessCamelCase",
+ * the value of the given attribute. The name of the attribute will
Review comment:
Well ... they call them attributes because that's what they happen to be in
those cases: attributes on an LDAP object and attributes on a CAS principal. I
don't think that will fit in the general case, where we are providing a
`TokenName` class to serve as a convenience for extensions that wish to
generate tokens dynamically. Those tokens may come from something called an
attribute, perhaps even Guacamole's own attributes, or they may not.
There's a similar function on the JavaScript side for translation strings
which we called `canonicalize()`:
https://github.com/apache/guacamole-client/blob/d1e928bea79ca81c827e9b6adedabc98eefdf701/guacamole/src/main/webapp/app/locale/services/translationStringService.js#L28-L42
Perhaps that would be a better choice?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
