mike-jumper commented on a change in pull request #303: GUACAMOLE-579: Get user
attributes from CAS ticket
URL: https://github.com/apache/guacamole-client/pull/303#discussion_r296459616
##########
File path:
guacamole-ext/src/main/java/org/apache/guacamole/token/TokenName.java
##########
@@ -102,5 +100,21 @@ public static String fromAttribute(String name) {
return builder.toString();
}
+
+ /**
+ * Generate the name of a parameter from the given string, and with a blank
+ * prefix such that the token name will simply be the transformed version
+ * of the string.
Review comment:
While it's relatively clear that this version of `canonicalize()` is meant
to perform the same task as the other version of `canonicalize()`, this isn't
specifically noted. For the sake of the caller, the transformation performed
should be independently described, or the documentation should at least link to
the other version and note that the same transformation is performed (except
with no prefix).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
