mike-jumper commented on a change in pull request #111: GUACAMOLE-422: Document
support for timezone handshake and parameter.
URL: https://github.com/apache/guacamole-manual/pull/111#discussion_r296458514
##########
File path: src/chapters/protocol.xml
##########
@@ -80,6 +80,22 @@
it supports Ogg Vorbis audio, but no video, and can accept both
PNG and JPEG images. It
wants to connect to localhost at port 5900, and is leaving the
three other parameters
blank.</para>
+ <para>Version 1.1.0 of Guacamole adds a couple of other features to
the handshake phase. First,
Review comment:
I'm not sure about listing new changes within the documentation as a set of
layered changes. I feel that the documentation for version X really should be a
reference for version X first, with other relevant information (protocol is
different in older versions) being secondary.
What do you think of instead describing things strictly from the perspective
of the way things are in this version? I think it would make more sense for the
section to describe the protocol of the latest version with a note about the
behavior of older versions, rather than a section mainly describing older
versions with a note about the behavior of the latest.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
