mike-jumper commented on a change in pull request #111: GUACAMOLE-422: Document support for timezone handshake and parameter. URL: https://github.com/apache/guacamole-manual/pull/111#discussion_r308978519
########## File path: src/references/instructions/client/handshake/timezone.xml ########## @@ -0,0 +1,14 @@ +<?xml version="1.0" encoding="UTF-8"?> + +<section xml:id="timezone-handshake-instruction" + xmlns="http://docbook.org/ns/docbook" version="5.0" xml:lang="en" + xmlns:xi="http://www.w3.org/2001/XInclude"> + <title>timezone</title> + <indexterm> + <primary>timezone</primary> + </indexterm> + <para>Specifies the timezone of the client system, in IANA zone key format. + This is a single-value parameter, and may be used by protocols to Review comment: As the `timezone` instruction has static set of parameters (just the one parameter), those should be documented in the same manner as the other instructions. For example: https://github.com/apache/guacamole-manual/blob/33e653ccf99cbb7b978719b6ec2cc07a0e8bed30/src/references/instructions/client/control/sync.xml#L17-L24 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
