mike-jumper commented on a change in pull request #232: GUACAMOLE-514:
Implement additional VNC authentication support
URL: https://github.com/apache/guacamole-server/pull/232#discussion_r312197439
##########
File path: src/protocols/vnc/auth.c
##########
@@ -31,3 +31,25 @@ char* guac_vnc_get_password(rfbClient* client) {
return ((guac_vnc_client*) gc->data)->settings->password;
}
+rfbCredential* guac_vnc_get_credentials(rfbClient* client, int credentialType)
{
+ guac_client* gc = rfbClientGetClientData(client, GUAC_VNC_CLIENT_KEY);
+ rfbCredential *creds = malloc(sizeof(rfbCredential));
+
+ if (credentialType == rfbCredentialTypeUser) {
+ creds->userCredential.username = ((guac_vnc_client*)
gc->data)->settings->username;
+ creds->userCredential.password = ((guac_vnc_client*)
gc->data)->settings->password;
+ return creds;
+ }
+
+ else if (credentialType == rfbCredentialTypeX509) {
+ creds->x509Credential.x509ClientCertFile = ((guac_vnc_client*)
gc->data)->settings->client_cert;
Review comment:
Yeah, I agree that writing credentials to temporary files on disk is not the
way to go.
Perhaps the username half of this should be split away from the X.509 half?
That would narrow scope to something that's definitely solvable. Supporting
X.509 might need to wait for improvements to the underlying library.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
