mike-jumper commented on a change in pull request #232: GUACAMOLE-514:
Implement additional VNC authentication support
URL: https://github.com/apache/guacamole-server/pull/232#discussion_r312567092
##########
File path: src/protocols/vnc/auth.c
##########
@@ -31,3 +31,19 @@ char* guac_vnc_get_password(rfbClient* client) {
return ((guac_vnc_client*) gc->data)->settings->password;
}
+rfbCredential* guac_vnc_get_credentials(rfbClient* client, int credentialType)
{
+ guac_client* gc = rfbClientGetClientData(client, GUAC_VNC_CLIENT_KEY);
+ guac_vnc_settings* settings = ((guac_vnc_client*) gc->data)->settings;
+
+ if (credentialType == rfbCredentialTypeUser) {
+ rfbCredential *creds = malloc(sizeof(rfbCredential));
+ creds->userCredential.username = settings->username;
+ creds->userCredential.password = settings->password;
+ return creds;
+ }
+
+ guac_client_log(gc, GUAC_LOG_ERROR,
+ "Unsupported credential type requested.");
Review comment:
Sure, makes perfect sense.
In that case, I would recommend:
1. Using `guac_client_abort()`, so this is explicitly fatal to the
connection.
2. Additionally logging the credential type that's unsupported, at least at
the debug level.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
