mike-jumper commented on a change in pull request #345: GUACAMOLE-234: Migrate
to Apache Directory API for LDAP Extension
URL: https://github.com/apache/guacamole-client/pull/345#discussion_r312720162
##########
File path:
extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/ObjectQueryService.java
##########
@@ -178,6 +169,9 @@ public String generateQuery(String filter,
*
* @param query
* The LDAP query to execute.
+ *
+ * @param searchHop
+ * The level of depth for this search, used for tracking referrals.
Review comment:
Reading this description, I'm somewhat confused about what `searchHop` is.
Is this the current depth of the search? Or the maximum depth? I think this
should be made a bit clearer.
The code within the function looks like the former.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
