mike-jumper commented on a change in pull request #345: GUACAMOLE-234: Migrate
to Apache Directory API for LDAP Extension
URL: https://github.com/apache/guacamole-client/pull/345#discussion_r312756059
##########
File path: extensions/guacamole-auth-ldap/pom.xml
##########
@@ -141,11 +141,17 @@
<scope>provided</scope>
</dependency>
- <!-- JLDAP -->
+ <!-- Apache Directory LDAP API -->
<dependency>
- <groupId>com.novell.ldap</groupId>
- <artifactId>jldap</artifactId>
- <version>4.3</version>
+ <groupId>org.apache.directory.api</groupId>
+ <artifactId>api-all</artifactId>
Review comment:
With things switching from JLDAP to Apache Directory API, the `LICENSE` file
and bundled licenses will need to be updated, too:
https://github.com/apache/guacamole-client/blob/8b172a98fc77241664be16e7f40ab4add510c73a/extensions/guacamole-auth-ldap/src/licenses/LICENSE#L232-L243
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
