mike-jumper commented on a change in pull request #437: GUACAMOLE-769: Polish
the RADIUS challenge box
URL: https://github.com/apache/guacamole-client/pull/437#discussion_r312751834
##########
File path:
extensions/guacamole-auth-radius/src/main/java/org/apache/guacamole/auth/radius/AuthenticationProviderService.java
##########
@@ -97,13 +106,17 @@ private CredentialsInfo getRadiusChallenge(RadiusPacket
challengePacket) {
}
// We have the required attributes - convert to strings and then
generate the additional login box/field
- String replyMsg = replyAttr.toString();
+ logger.debug("Received challenge: {}", replyAttr.toString());
+ String replyMsg = replyAttr.toString().split(" = ", 2)[1];
Review comment:
Would `replyAttr.getValue()` work here? Formatting the `RadiusAttribute` as
a string and then re-parsing it back into an attribute feels like it shouldn't
be necessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
