mike-jumper commented on a change in pull request #437: GUACAMOLE-769: Polish the RADIUS challenge box URL: https://github.com/apache/guacamole-client/pull/437#discussion_r312752301
########## File path: extensions/guacamole-auth-radius/src/main/java/org/apache/guacamole/auth/radius/form/GuacamoleRadiusChallenge.java ########## @@ -0,0 +1,77 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.guacamole.auth.radius.form; + +import org.apache.guacamole.net.auth.credentials.CredentialsInfo; + +/** + * A class for storing the RADIUS challenge message and expected credentials + * in a single object. + */ +public class GuacamoleRadiusChallenge { + + /** + * The challenge text sent by the RADIUS server. + */ + private final String challengeText; + + /** + * The expected credentials that need to be provided to satisfy the + * RADIUS authentication challenge. + */ + private final CredentialsInfo expectedCredentials; + + /** + * Create a new GuacamoleRadiusChallenge object with the provided Review comment: Convention for the first part of a function's JavaDoc documentation is a present tense sentence fragment - the portion that would follow the implied "This function" beginning of that sentence. To follow that convention, you'll want "Creates a new ..." here, not "Create a new ...". The latter is more the style of git commit messages. ;) Same with the "Return the ..." phrasing below. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
