mike-jumper commented on a change in pull request #439: GUACAMOLE-234: Fix
resource leaks in new LDAP code.
URL: https://github.com/apache/guacamole-client/pull/439#discussion_r313023974
##########
File path:
extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/ObjectQueryService.java
##########
@@ -223,10 +224,11 @@ else if (results.isReferral() &&
request.isFollowReferrals()) {
}
+ results.close();
Review comment:
In fact ... I think the same implicit `close()` from `try`-with-resources
would work with `LdapNetworkConnection`, as well. It implements `AutoCloseable`
just as `SearchCursor` does.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
