necouchman commented on issue #439: GUACAMOLE-234: Fix resource leaks in new LDAP code. URL: https://github.com/apache/guacamole-client/pull/439#issuecomment-520510037 @mike-jumper: Okay, reworked both those instances with `try...finally` blocks - let me know if that looks okay. It'll change the error reporting in the method from `LDAPConnectionService` that was changed, but I think it's still acceptable.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
