XYUU commented on a change in pull request #453: GUACAMOLE-903: Improved
Chinese internationalization support
URL: https://github.com/apache/guacamole-client/pull/453#discussion_r355984949
##########
File path:
guacamole/src/main/webapp/app/form/controllers/languageFieldController.js
##########
@@ -40,7 +40,7 @@ angular.module('form').controller('languageFieldController',
['$scope', '$inject
// Retrieve defined languages
languageService.getLanguages().then(function languagesRetrieved(languages)
{
- $scope.$apply(function updateLanguageOptions() {
+ $scope.$applyAsync(function updateLanguageOptions() {
Review comment:
I have explained the reason for this change in jira.
I found that there is a script error in the front end when setting the
default internationalization. This error is caused by the wrong use of angular
ajax request. I checked the information and fixed the problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
