XYUU commented on a change in pull request #453: GUACAMOLE-903: Improved
Chinese internationalization support
URL: https://github.com/apache/guacamole-client/pull/453#discussion_r355981406
##########
File path:
guacamole/src/main/webapp/app/form/controllers/languageFieldController.js
##########
@@ -40,7 +40,7 @@ angular.module('form').controller('languageFieldController',
['$scope', '$inject
// Retrieve defined languages
languageService.getLanguages().then(function languagesRetrieved(languages)
{
- $scope.$apply(function updateLanguageOptions() {
+ $scope.$applyAsync(function updateLanguageOptions() {
Review comment:
@necouchman
You're right, but there is something else hidden. At first I just wanted to
fix this js error so that I could choose Chinese localization. After fixing it,
I found that the localization was incomplete, and then I completed it.
This is a bug that I fixed that would cause an existing script error, I
fixed it, and if I don't modify it here, my commit may not work.
I did a simple test, it was fixed, and it worked fine.
Unfortunately I don't have the ability to write unit tests for this
modification at this time because it is beyond my ability to do so.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
