necouchman commented on a change in pull request #243: GUACAMOLE-249: Migrate
to FreeRDP 2.x
URL: https://github.com/apache/guacamole-server/pull/243#discussion_r363062887
##########
File path: src/protocols/rdp/bitmap.h
##########
@@ -66,8 +61,11 @@ typedef struct guac_rdp_bitmap {
*
* @param bitmap
* The bitmap to cache.
+ *
+ * @return
+ * TRUE if successful, FALSE otherwise.
Review comment:
This all seem to be switching from `void` to `BOOL`, but they also always
seem to be returning `TRUE` - is there a rational for making them return
something, when it's always expected to be successful?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
