mike-jumper commented on a change in pull request #243: GUACAMOLE-249: Migrate
to FreeRDP 2.x
URL: https://github.com/apache/guacamole-server/pull/243#discussion_r365555236
##########
File path: src/protocols/rdp/bitmap.h
##########
@@ -66,8 +61,11 @@ typedef struct guac_rdp_bitmap {
*
* @param bitmap
* The bitmap to cache.
+ *
+ * @return
+ * TRUE if successful, FALSE otherwise.
Review comment:
In this case, no, I don't believe so. I was probably just on a roll with
`BOOL`-ing everything.
I'll recheck the body of the function and switch things back to `void` if
`BOOL` is not needed. The fewer things need changing, the better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
