mike-jumper commented on a change in pull request #243: GUACAMOLE-249: Migrate
to FreeRDP 2.x
URL: https://github.com/apache/guacamole-server/pull/243#discussion_r365556619
##########
File path: src/protocols/rdp/bitmap.h
##########
@@ -66,8 +61,11 @@ typedef struct guac_rdp_bitmap {
*
* @param bitmap
* The bitmap to cache.
+ *
+ * @return
+ * TRUE if successful, FALSE otherwise.
Review comment:
Regarding the other cases, yes - the other functions are written to comply
with the API of the FreeRDP library, which does require a `BOOL` return to
signal failures, even if our implementation doesn't have a failure condition in
most (all?) cases.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
