mike-jumper commented on a change in pull request #159: GUACAMOLE-465:
beginning to support new codecs and containers
URL: https://github.com/apache/guacamole-server/pull/159#discussion_r371049059
##########
File path: src/guacenc/ffmpeg-compat.c
##########
@@ -51,8 +51,38 @@
*/
static int guacenc_write_packet(guacenc_video* video, void* data, int size) {
- /* Write data, logging any errors */
- if (fwrite(data, 1, size, video->output) == 0) {
+ int ret;
+
+#if LIBAVCODEC_VERSION_INT < AV_VERSION_INT(54,1,0)
+ AVPacket pkt;
+ /* have to create a packet around the encoded data we have */
Review comment:
This isn't a deal-breaker for me, but as a point of consistency in style,
this comment (`/* all lowercase */`) doesn't match the style of existing
comments (`/* Sentence case */`). I would recommend making things consistent.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
