mike-jumper commented on a change in pull request #159: GUACAMOLE-465: beginning to support new codecs and containers URL: https://github.com/apache/guacamole-server/pull/159#discussion_r371048547
########## File path: src/guacenc/ffmpeg-compat.h ########## @@ -78,5 +78,70 @@ */ int guacenc_avcodec_encode_video(guacenc_video* video, AVFrame* frame); +/** + * Creates and sets up the AVCodecContext for the appropriate version + * of libavformat installed + * + * @param stream + * The open AVStream + * + * @param codec + * The codec used on the AVStream + * + * @param bitrate + * The target bitrate for the encoded video + * + * @param width + * The target width for the encoded video + * + * @param height + * The target width for the encoded video + * + * @param gop_size + * The size of the Group of Pictures + * + * @param qmax + * The max value of the quantizer + * + * @param qmin + * The min value of the quantizer + * + * @param pix_fmt + * The target pixel format for the encoded video + * + * @param time_base + * The target time base for the encoded video + * + */ +AVCodecContext* guacenc_build_avcodeccontext(AVStream* stream, AVCodec* codec, + int bitrate, int width, int height, int gop_size, int qmax, int qmin, + int pix_fmt, AVRational time_base); Review comment: Looks like the documentation for the return value is missing here. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
