mike-jumper commented on a change in pull request #469: GUACAMOLE-890: Security: Allow image to run as non-root user URL: https://github.com/apache/guacamole-client/pull/469#discussion_r373092391
########## File path: Dockerfile ########## @@ -56,6 +56,14 @@ WORKDIR /opt/guacamole # Copy artifacts from builder image into this image COPY --from=builder /opt/guacamole/ . +# Turn on the Remote IP Valve +RUN sed -i 's+^\( </Host>\)+ <Valve className="org.apache.catalina.valves.RemoteIpValve" />\n\1+' /usr/local/tomcat/conf/server.xml + +# Allow image to run as non-root user +RUN sed -i 's/unpackWARs="true"/unpackWARs="false"/' /usr/local/tomcat/conf/server.xml +RUN chmod 777 /usr/local/tomcat/temp Review comment: This looks dangerous. Reducing privileges is a good thing, but removing existing restrictions from Tomcat's internals in order to achieve that seems a step in the wrong direction. That would be effectively granting privileges. Assuming it is possible to configure the Tomcat portion of the image such that it can be run as a lower-privilege user, we should find a way to do that which doesn't lessen the security restrictions already in place. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
