benrubson commented on a change in pull request #469: GUACAMOLE-890: Security: Allow image to run as non-root user URL: https://github.com/apache/guacamole-client/pull/469#discussion_r373118138
########## File path: Dockerfile ########## @@ -56,6 +56,14 @@ WORKDIR /opt/guacamole # Copy artifacts from builder image into this image COPY --from=builder /opt/guacamole/ . +# Turn on the Remote IP Valve +RUN sed -i 's+^\( </Host>\)+ <Valve className="org.apache.catalina.valves.RemoteIpValve" />\n\1+' /usr/local/tomcat/conf/server.xml Review comment: I've hardened the `sed` expression to be more robust to potential indentation changes. It's an easy one-line update, and is now robust IMO. Of course feel free to tell me if I should rather go with a `patch` command. Thank you ! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
