mike-jumper commented on a change in pull request #546:
URL: https://github.com/apache/guacamole-client/pull/546#discussion_r449823359
##########
File path:
guacamole-ext/src/main/java/org/apache/guacamole/net/auth/ActivityRecordSet.java
##########
@@ -56,6 +56,24 @@
* If an error occurs while retrieving the records within this set.
*/
Collection<RecordType> asCollection() throws GuacamoleException;
+
+ /**
+ * Returns records within this set for the item having the specified
+ * identifier as a standard Collection.
+ *
+ * @param identifier
+ * The identifier of the underlying item that the collection
+ * should be limited to.
+ *
+ * @return
+ * A collection containing records within this set for the specified
+ * identifier.
+ *
+ * @throws GuacamoleException
+ * If an error occurs while retrieving the records within this set.
+ */
+ Collection<RecordType> asCollection(String identifier)
+ throws GuacamoleException;
Review comment:
Another possibility could be to add something like
`getConnectionHistory()` and `getUserHistory()` (returning `ActivityRecordSet`
like their `UserContext` versions) to `Connection` and `User` respectively,
deprecating the old `getHistory()`.
That seems clean but would also lend itself well to default implementations
(could just wrap `getHistory()` in some sort of basic `ActivityRecordSet`
implementation).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
