necouchman commented on a change in pull request #546:
URL: https://github.com/apache/guacamole-client/pull/546#discussion_r449824722
##########
File path:
guacamole/src/main/java/org/apache/guacamole/rest/history/HistoryResource.java
##########
@@ -86,8 +93,9 @@ public HistoryResource(UserContext userContext) {
* If an error occurs while retrieving the connection history.
*/
@GET
- @Path("connections")
+ @Path("connections{p:/?}{identifier : ([0-9]+)?}")
public List<APIConnectionRecord> getConnectionHistory(
+ @PathParam("identifier") String identifier,
Review comment:
Ah, okay. I think I misunderstood your response to my question in Slack
- I thought you were saying the existing API endpoint should be removed in
favor of the common `history` endpoint that is already filter-able.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
