necouchman commented on a change in pull request #546:
URL: https://github.com/apache/guacamole-client/pull/546#discussion_r514358894
##########
File path:
extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/user/UserService.java
##########
@@ -581,13 +581,9 @@ protected ActivityRecord
getObjectInstance(ActivityRecordModel model) {
ModeledUser user) throws GuacamoleException {
String username = user.getIdentifier();
-
- // Retrieve history only if READ permission is granted
- if (hasObjectPermission(authenticatedUser, username,
ObjectPermission.Type.READ))
- return getObjectInstances(userRecordMapper.select(username));
Review comment:
Similar to above - call is delegated down to another `retrieveHistory()`
call which checks `user.isPrivileged()` and then uses
`userMapper.searchReadable()` for unprivileged users to gather readable user
records.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
