mike-jumper commented on a change in pull request #546:
URL: https://github.com/apache/guacamole-client/pull/546#discussion_r514562005
##########
File path:
extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/connection/ConnectionService.java
##########
@@ -411,28 +411,16 @@ protected ConnectionRecord
getObjectInstance(ConnectionRecordModel model) {
ModeledConnection connection) throws GuacamoleException {
String identifier = connection.getIdentifier();
-
- // Retrieve history only if READ permission is granted
- if (hasObjectPermission(user, identifier, ObjectPermission.Type.READ))
{
Review comment:
Right - `getActiveConnections()` is required to only return connections
visible to the current user.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
