mike-jumper commented on pull request #505: URL: https://github.com/apache/guacamole-client/pull/505#issuecomment-783097870
So, I've been plowing through the PR backlog and came across these changes. Pulling them to test things out locally, I see the new menu option:  but clicking "Lock keyboard" seems to have no effect, at least when testing from my Chromebook. The Guacamole menu closes as a result of clicking the menu item, but that's it. Is there something I'm missing? Regarding the functionality itself: * We should probable use a different icon. * What if the user wishes to unlock the keyboard? Should this be a checkbox? * Would locating this elsewhere within Guacamole menu be better? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
