necouchman commented on pull request #505: URL: https://github.com/apache/guacamole-client/pull/505#issuecomment-783325847
> but clicking "Lock keyboard" seems to have no effect, at least when testing from my Chromebook. Yeah, that was my experience, too, and I'm not sure what I'm doing wrong. I put it out here for folks to test out, but clearly something isn't quite right. Doing some additional reading on the API, it sounds like it only works if you first go into full-screen mode, so that may be part of the issue. It's been a while since I played around with it, and I cannot remember if that was part of my testing. > We should probable use a different icon. Sure - I'm not much of a graphics person, and I'm not sure where the existing graphics came from, but open to suggestions. > What if the user wishes to unlock the keyboard? Should this be a checkbox? Possibly so - it seems like a 2-5 second hold on the Escape key, at least in Chrome, is what is supposed to forcibly unlock the keyboard. At least one of the considerations should probably be whether enabling keyboard lock (in a way that actually functions) would prevent the Guacamole menu from being accessed at all? > Would locating this elsewhere within Guacamole menu be better? I am totally open to suggestions - no serious ties to any of the current way its implemented, where it's located, etc. https://web.dev/keyboard-lock/ https://developer.mozilla.org/en-US/docs/Web/API/Keyboard/lock https://wicg.github.io/keyboard-lock/ ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
