[GitHub] [guacamole-client] mike-jumper commented on pull request #616: GUACAMOLE-773: Update all JavaScript dependencies to latest versions.

[GitBox]

mike-jumper commented on pull request #616:
URL: https://github.com/apache/guacamole-client/pull/616#issuecomment-853409310


   So far, I'm seeing the following regressions:
   
   * The pagination directive changed from this:
   
     ![Working pagination 
directive](https://user-images.githubusercontent.com/4632905/120557166-5d30b400-c3b2-11eb-9e30-1e99a069f72a.png)
   
     to this:
   
     ![Broken pagination 
directive](https://user-images.githubusercontent.com/4632905/120557207-6caffd00-c3b2-11eb-8515-c64a334eb370.png)
   
   * The "Pickr" color picker is no longer detected as unavailable on IE10 and 
IE11. The service handling initialization of the Pickr library should be 
recognizing that things will not work and mark Pickr as unavailable, but this 
isn't happening.
   
   We should also review and check against the 1.6.x to 1.7.x migration guide 
for AngularJS:
   
   https://docs.angularjs.org/guide/migration#migrating-from-1-6-to-1-7
   
   There are no applicable breaking changes for 1.7.x to 1.8.x, which affected 
only jqLite (we use full jQuery instead of this).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org