mike-jumper commented on a change in pull request #616:
URL: https://github.com/apache/guacamole-client/pull/616#discussion_r644459209
##########
File path: guacamole/src/main/frontend/src/app/index/indexModule.js
##########
@@ -17,22 +17,37 @@
* under the License.
*/
+require('angular-module-shim.js');
+require('relocateParameters.js');
+
+require('angular-translate-interpolation-messageformat');
+require('angular-translate-loader-static-files');
+
/**
* The module for the root of the application.
*/
angular.module('index', [
+
+ require('angular-route'),
+ require('angular-translate'),
+
'auth',
'client',
'clipboard',
'home',
'login',
'manage',
'navigation',
- 'ngRoute',
- 'ngTouch',
'notification',
- 'pascalprecht.translate',
'rest',
'settings',
+
Review comment:
I thought it made sense to visually separate things into three groups:
* AngularJS modules from external libraries
* AngularJS modules we define ourselves with actual code
* AngularJS modules that are generated at build time (just `templates-main`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
