necouchman commented on pull request #349: URL: https://github.com/apache/guacamole-server/pull/349#issuecomment-945939545
A couple of comments, here: * The pull request needs to be limited to a specific JIRA issue, or split out into two different pull requests. I'd recommend just picking one and going with it, and we can close out the other JIRA issue as "resolved by XXX". * Does this introduce any minimum version requirements for libssh2 that might impact people currently using it? I'm thinking, most specifically, of the stock libssh2 included with things like CentOS/RHEL7, which is probably going to be a bit outdated. We should, at the very least, know if it introduces a version requirement, and, if it does, discuss if we're good having the code move to that minimum version requirement (and deal with it in configure, Makefile, etc.), or support both. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
