roysjosh commented on pull request #349: URL: https://github.com/apache/guacamole-server/pull/349#issuecomment-945952355
Hey @necouchman, thanks for taking a look. Switching to libssh2 parsing the keys technically solves both issues (so long as libssh2 is compiled with OpenSSL) so I'll arbitrarily pick 745. `libssh2_userauth_publickey_frommemory` was added in libssh2 1.6.0 (June 12 2015) so I think we're okay from that perspective: https://github.com/libssh2/libssh2/blob/5627b82be66135dbda6423ae10bcad1c9ac86f9d/docs/libssh2_userauth_publickey_frommemory.3#L54 ed25519 & OpenSSH key support were added in 1.9.0. It looks like CentOS 7 has 1.8.0. I'll try to find time this week to test this patch on CentOS 7 and see if anything explodes. Hopefully PEM RSA/DSA, both encrypted and plaintext, continue to function... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
