jmuehlner commented on a change in pull request #373:
URL: https://github.com/apache/guacamole-server/pull/373#discussion_r812546519
##########
File path: src/protocols/kubernetes/argv.c
##########
@@ -53,8 +53,9 @@ int guac_kubernetes_argv_callback(guac_user* user, const
char* mimetype,
}
/* Update Kubernetes terminal size */
- guac_kubernetes_resize(client, terminal->term_height,
- terminal->term_width);
+ guac_kubernetes_resize(client,
+ guac_terminal_term_height(terminal),
+ guac_terminal_term_width(terminal));
Review comment:
Yeah, I don't love these names. It's kinda nice to have them named the
same as the property they're accessing, but yeah I'd be happy to change them to
something like `guac_terminal_get_rows`. It doesn't really match the style of
the file - not a lot of getters with `get` in the name, but if you're ok with
it, I'm definitely down.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
