mike-jumper commented on a change in pull request #373:
URL: https://github.com/apache/guacamole-server/pull/373#discussion_r813583736
##########
File path: src/protocols/kubernetes/argv.c
##########
@@ -67,20 +68,20 @@ void* guac_kubernetes_send_current_argv(guac_user* user,
void* data) {
/* Send current color scheme */
guac_user_stream_argv(user, user->socket, "text/plain",
- GUAC_KUBERNETES_ARGV_COLOR_SCHEME, terminal->color_scheme);
+ GUAC_KUBERNETES_ARGV_COLOR_SCHEME,
+ guac_terminal_color_scheme(terminal));
Review comment:
For consistency with things like `guac_terminal_get_rows()`, I think
this (and anything similar) should be renamed to
`guac_terminal_get_color_scheme()`.
##########
File path: src/terminal/color_scheme.c
##########
@@ -19,7 +19,7 @@
#include "config.h"
-#include "terminal/color-scheme.h"
+#include "terminal/color_scheme.h"
Review comment:
Hm ... I think these should be renamed back. If the rest of the library
is following an underscore convention for filenames, I'd lean toward migrating
that to dashes as part of public-ifying the library. The dash convention is the
convention already used by libguac for its public headers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
