mike-jumper commented on code in PR #764:
URL: https://github.com/apache/guacamole-client/pull/764#discussion_r982695729
##########
guacamole-common-js/src/main/webapp/modules/Client.js:
##########
@@ -42,7 +42,36 @@ Guacamole.Client = function(tunnel) {
var currentState = STATE_IDLE;
var currentTimestamp = 0;
- var pingInterval = null;
+
+ /**
+ * The rough number of milliseconds to wait between sending keep-alive
+ * pings. This may vary depending on how frequently the browser allows
+ * timers to run, as well as how frequently the client receives messages
+ * from the server.
+ *
+ * @private
+ * @constant
+ * @type {!number}
+ */
+ var KEEP_ALIVE_FREQUENCY = 5000;
Review Comment:
Yes, except that the guacamole-common-js build does not currently leverage
the same sort of JavaScript compatibility compilation. We're safe to use new
fanciness like `const` and `let` within the webapp, but guacamole-common-js
would need to migrate from `minify-maven-plugin` to `frontend-maven-plugin` to
get those build tools and associated benefits.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
