mike-jumper commented on code in PR #764:
URL: https://github.com/apache/guacamole-client/pull/764#discussion_r982707364


##########
guacamole-common-js/src/main/webapp/modules/Tunnel.js:
##########
@@ -933,6 +958,16 @@ Guacamole.WebSocketTunnel = function(tunnelURL) {
             tunnel.setState(Guacamole.Tunnel.State.UNSTABLE);
         }, tunnel.unstableThreshold);
 
+        var currentTime = new Date().getTime();
+        var pingDelay = Math.max(lastSentPing + PING_FREQUENCY - currentTime, 
0);
+
+        // Ping tunnel endpoint regularly to test connection stability, sending

Review Comment:
   >Where is this happening regularly?
   
   Only in response to data received from the server. Here, within the 
WebSocket tunnel, that will happen every time a `ping` is sent, as the server 
responds to all received pings with a duplicate ping.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to