robert-scheck commented on PR #407: URL: https://github.com/apache/guacamole-server/pull/407#issuecomment-1368273508
> Beyond the one issue I see with the `goto` block, I'm wondering if we should do some verification that the underlying `libav`* libraries support the codecs we're trying to add. We currently do not do any checking to make sure that MP4 is supported - I don't know if MP4 is always supported in `libav`*, or if we're just assuming that, if you have it, you also have it compiled with MP4 support. It seems like maybe there's an opportunity, here, to make this a little more dynamic and verify that we actually support the codecs we're implementing by doing some build-time checks - at the very least to insure that support is included for the ones we have listed, here, if not to dynamically determine which ones we should include. Honestly, I'm not sure whether my C programming skills are good enough for this. What I figured out during my tests: - If `libav`* doesn't support MP4, `guacenc` simply fails with a `libav`* (?) specific error message (and same applies for possibly missing VPx support). Yes, maybe not great but just works. - I would like to avoid build-time checks for `libav`* codec support, because 3rd-party repositories provide alternative `libav`* with MP4 support for Fedora (suited as run-time drop-in replacements). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
