necouchman commented on PR #407: URL: https://github.com/apache/guacamole-server/pull/407#issuecomment-1368276458
> > * If `libav`* doesn't support MP4, `guacenc` simply fails with a `libav`* (?) specific error message (and same applies for possibly missing VPx support). Yes, maybe not great but just works. > * I would like to avoid build-time checks for `libav`* codec support, because 3rd-party repositories provide alternative `libav`* with MP4 support for Fedora (suited as run-time drop-in replacements). I see your point, and I'm not hung up on this, but it seems like, since you're building guacd, it'd be better to check for supported codecs at build-time and warn the person building the software about it, and have them have to re-build it, versus silently continuing and getting into a situation where a particular codec just doesn't work and you have to go run down the root cause and then swap the library out. Also, it matches how the rest of the guacd build process behaves - if you don't have the libssh2 build components available, SSH support is disabled and you have to go install it and then re-build. Anyway, just my opinion and I'm not hung up about it - it sounds like @mike-jumper is okay with it without the other checks, so that's fine. > * `libav`* (?) seems to be picky about the filename extension; just passing "libvpx" but still having the `.m4v` leads to a failure. Not sure where to get proper filename extensions per codec. As Mike suggested, it might be better to create a structure that associates codecs with extensions to properly track this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
