jmuehlner commented on code in PR #796:
URL: https://github.com/apache/guacamole-client/pull/796#discussion_r1114844082
##########
guacamole/src/main/frontend/src/app/clipboard/directives/guacClipboard.js:
##########
@@ -47,6 +47,12 @@ angular.module('clipboard').directive('guacClipboard',
['$injector',
config.controller = ['$scope', '$injector', '$element',
function guacClipboardController($scope, $injector, $element) {
+ /**
+ * Set to true if the clipboard data should be displayed in the
+ * Clipboard Editor. Otherwise, false.
+ */
+ var shouldDisplay = false;
Review Comment:
To match the existing code style of other variables declared here, this
should have a `@type` annotation.
##########
guacamole/src/main/frontend/src/app/clipboard/directives/guacClipboard.js:
##########
@@ -92,6 +110,12 @@ angular.module('clipboard').directive('guacClipboard',
['$injector',
// that indicate the clipboard field may have been changed
element.addEventListener('input', updateClipboardData);
element.addEventListener('change', updateClipboardData);
+ element.addEventListener('focus', displayAndUpdateClipboardEditor);
+
+ // Update remote clipboard if local clipboard changes
Review Comment:
Is this copy pasta? Looks like it's a verbatim copy of the block directly
below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
