jmuehlner commented on code in PR #796:
URL: https://github.com/apache/guacamole-client/pull/796#discussion_r1115010730
##########
guacamole/src/main/frontend/src/app/clipboard/directives/guacClipboard.js:
##########
@@ -92,12 +119,20 @@ angular.module('clipboard').directive('guacClipboard',
['$injector',
// that indicate the clipboard field may have been changed
element.addEventListener('input', updateClipboardData);
element.addEventListener('change', updateClipboardData);
+ element.addEventListener('focus', displayAndUpdateClipboardEditor);
+
// Update remote clipboard if local clipboard changes
$scope.$on('guacClipboard', function clipboardChanged(event, data) {
updateClipboardEditor(data);
});
+ // Update the prefocus clipboard editor message
+ guacTranslate('CLIENT.TEXT_CLIPBOARD_AWAITING_FOCUS', '').then(
Review Comment:
Also, what if a user literally has the text "Focus here to view clipboard
data..." in their clipboard?
Having some quick visual method to clearly identify that the clipboard is
inactive would be nice. Rather than just sticking a message into the textarea -
how about visually disabling (greying out, etc) the textarea and rendering a
message in a different spot where it couldn't be confused with actual clipboard
contents?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
