mike-jumper commented on code in PR #809:
URL: https://github.com/apache/guacamole-client/pull/809#discussion_r1142458229
##########
guacamole/src/main/frontend/src/translations/en.json:
##########
@@ -183,6 +183,79 @@
},
+ "IMPORT": {
+
+ "ACTION_ACKNOWLEDGE" : "@:APP.ACTION_ACKNOWLEDGE",
+
+ "BUTTON_CANCEL": "Cancel",
+ "BUTTON_CLEAR": "Clear",
+ "BUTTON_IMPORT": "Import Connections",
+
+ "CONNECTIONS_IMPORTED_SUCCESS": "{NUMBER} connections imported
successfully.",
Review Comment:
You'll need to use pluralization here so that "connection" vs. "connections"
is chosen appropriately based on the value of `NUMBER`.
##########
guacamole/src/main/frontend/src/translations/en.json:
##########
@@ -183,6 +183,79 @@
},
+ "IMPORT": {
+
+ "ACTION_ACKNOWLEDGE" : "@:APP.ACTION_ACKNOWLEDGE",
+
+ "BUTTON_CANCEL": "Cancel",
+ "BUTTON_CLEAR": "Clear",
+ "BUTTON_IMPORT": "Import Connections",
Review Comment:
The prefix for actions that may be taken, button or not, is `ACTION_`. Here,
for generic actions like "Cancel" and "Clear", they should be defined at the
`APP` level and then referenced.
##########
guacamole/src/main/frontend/src/translations/en.json:
##########
@@ -183,6 +183,79 @@
},
+ "IMPORT": {
+
+ "ACTION_ACKNOWLEDGE" : "@:APP.ACTION_ACKNOWLEDGE",
+
+ "BUTTON_CANCEL": "Cancel",
+ "BUTTON_CLEAR": "Clear",
+ "BUTTON_IMPORT": "Import Connections",
+
+ "CONNECTIONS_IMPORTED_SUCCESS": "{NUMBER} connections imported
successfully.",
+
+ "DIALOG_HEADER_ERROR" : "@:APP.DIALOG_HEADER_ERROR",
+ "DIALOG_HEADER_SUCCESS": "Success",
+
+ "FIELD_PLACEHOLDER_FILTER" : "@:APP.FIELD_PLACEHOLDER_FILTER",
+
+ "HEADER": "Connection Import",
+
+ "HELP_HEADER": "Connection Import File Format",
+
+ "HELP_FILE_TYPE_HEADER": "File Types",
+ "HELP_FILE_TYPE_DESCRIPTION" : "Three file types are supported for
connection import: CSV, JSON, and YAML. The same data may be specified by each
file type. This must include the connection name and protocol. Optionally, a
connection group location, a list of users and/or user groups to grant access,
connection parameters, or connection protocols may also be specified. Any users
or user groups that do not exist in the current data source will be
automatically created.",
+
+ "HELP_CSV_HEADER": "CSV Format",
+ "HELP_CSV_DESCRIPTION": "A connection import CSV file has one
connection record per row. Each column will specify a connection field. At
minimum the connection name and protocol must be specified.",
+ "HELP_CSV_MORE_DETAILS": "The CSV header for each row specifies the
connection field. The connection group ID that the connection should be
imported into may be directly specified with \"parentIdentifier\", or the path
to the parent group may be specified using \"group\" as shown below. In most
cases, there should be no conflict between fields, but if needed, an \"
(attribute)\" or \" (parameter)\" suffix may be added to disambiguate. Lists of
user or user group identifiers must be semicolon-seperated.¹",
+
+ "HELP_JSON_HEADER": "JSON Format",
+ "HELP_JSON_DESCRIPTION": "A connection import JSON file is a list of
connection objects. At minimum the connection name and protocol must be
specified in each connection object.",
+ "HELP_JSON_MORE_DETAILS": "The connection group ID that the connection
should be imported into may be directly specified with a \"parentIdentifier\"
field, or the path to the parent group may be specified using a \"group\" field
as shown below. An array of user and user group identifiers to grant access to
may be specified per connection.",
+
+ "HELP_YAML_HEADER": "YAML Format",
+ "HELP_YAML_DESCRIPTION": "A connection import YAML file is a list of
connection objects with exactly the same structure as the JSON format.",
+
+ "HELP_SEMICOLON_FOOTNOTE": "If present, semicolons can be escaped with
a backslash, e.g. \"first\\\\;last\"",
+
+ "ERROR_AMBIGUOUS_CSV_HEADER":
+ "Ambiguous CSV Header \"{HEADER}\" could be either a connection
attribute or parameter",
+ "ERROR_ARRAY_REQUIRED":
+ "The provided file must contain a list of connections",
+ "ERROR_DUPLICATE_CSV_HEADER":
+ "Duplicate CSV Header: {HEADER}",
+ "ERROR_EMPTY_FILE": "The provided file is empty",
+ "ERROR_INVALID_CSV_HEADER":
+ "Invalid CSV Header \"{HEADER}\" is neither an attribute or
parameter",
+ "ERROR_INVALID_GROUP": "No group matching \"{GROUP}\" found",
+ "ERROR_INVALID_FILE_TYPE":
+ "Unsupported file type: \"{TYPE}\"",
+ "ERROR_INVALID_USER_IDENTIFIERS":
+ "Users not found: {IDENTIFIER_LIST}",
+ "ERROR_INVALID_USER_GROUP_IDENTIFIERS":
+ "User Groups not found: {IDENTIFIER_LIST}",
+ "ERROR_NO_FILE_SUPPLIED": "Please select a file to import",
+ "ERROR_AMBIGUOUS_PARENT_GROUP":
+ "Both group and parentIdentifier may be not specified at the same
time",
+ "ERROR_REQUIRED_PROTOCOL":
+ "No connection protocol found in the provided file",
+ "ERROR_REQUIRED_NAME":
+ "No connection name found in the provided file",
+
+ "ERROR_FILE_SINGLE_ONLY": "Please upload only a single file at a time",
+
+ "TABLE_HEADER_NAME" : "Name",
+ "TABLE_HEADER_PROTOCOL" : "Protocol",
+ "TABLE_HEADER_ERRORS" : "Errors",
+ "TABLE_HEADER_ROW_NUMBER": "Row #",
+
+ "UPLOAD_FILE_TYPES": "CSV, JSON, or YAML",
+ "UPLOAD_HELP_LINK": "View Format Tips",
+ "UPLOAD_DROP_TITLE": "Drop a File Here",
Review Comment:
This is probably a `HELP_`.
##########
guacamole/src/main/frontend/src/translations/en.json:
##########
@@ -183,6 +183,79 @@
},
+ "IMPORT": {
+
+ "ACTION_ACKNOWLEDGE" : "@:APP.ACTION_ACKNOWLEDGE",
+
+ "BUTTON_CANCEL": "Cancel",
+ "BUTTON_CLEAR": "Clear",
+ "BUTTON_IMPORT": "Import Connections",
+
+ "CONNECTIONS_IMPORTED_SUCCESS": "{NUMBER} connections imported
successfully.",
+
+ "DIALOG_HEADER_ERROR" : "@:APP.DIALOG_HEADER_ERROR",
+ "DIALOG_HEADER_SUCCESS": "Success",
+
+ "FIELD_PLACEHOLDER_FILTER" : "@:APP.FIELD_PLACEHOLDER_FILTER",
+
+ "HEADER": "Connection Import",
+
+ "HELP_HEADER": "Connection Import File Format",
+
+ "HELP_FILE_TYPE_HEADER": "File Types",
+ "HELP_FILE_TYPE_DESCRIPTION" : "Three file types are supported for
connection import: CSV, JSON, and YAML. The same data may be specified by each
file type. This must include the connection name and protocol. Optionally, a
connection group location, a list of users and/or user groups to grant access,
connection parameters, or connection protocols may also be specified. Any users
or user groups that do not exist in the current data source will be
automatically created.",
+
+ "HELP_CSV_HEADER": "CSV Format",
+ "HELP_CSV_DESCRIPTION": "A connection import CSV file has one
connection record per row. Each column will specify a connection field. At
minimum the connection name and protocol must be specified.",
+ "HELP_CSV_MORE_DETAILS": "The CSV header for each row specifies the
connection field. The connection group ID that the connection should be
imported into may be directly specified with \"parentIdentifier\", or the path
to the parent group may be specified using \"group\" as shown below. In most
cases, there should be no conflict between fields, but if needed, an \"
(attribute)\" or \" (parameter)\" suffix may be added to disambiguate. Lists of
user or user group identifiers must be semicolon-seperated.¹",
+
+ "HELP_JSON_HEADER": "JSON Format",
+ "HELP_JSON_DESCRIPTION": "A connection import JSON file is a list of
connection objects. At minimum the connection name and protocol must be
specified in each connection object.",
+ "HELP_JSON_MORE_DETAILS": "The connection group ID that the connection
should be imported into may be directly specified with a \"parentIdentifier\"
field, or the path to the parent group may be specified using a \"group\" field
as shown below. An array of user and user group identifiers to grant access to
may be specified per connection.",
+
+ "HELP_YAML_HEADER": "YAML Format",
+ "HELP_YAML_DESCRIPTION": "A connection import YAML file is a list of
connection objects with exactly the same structure as the JSON format.",
+
+ "HELP_SEMICOLON_FOOTNOTE": "If present, semicolons can be escaped with
a backslash, e.g. \"first\\\\;last\"",
+
+ "ERROR_AMBIGUOUS_CSV_HEADER":
+ "Ambiguous CSV Header \"{HEADER}\" could be either a connection
attribute or parameter",
+ "ERROR_ARRAY_REQUIRED":
+ "The provided file must contain a list of connections",
+ "ERROR_DUPLICATE_CSV_HEADER":
+ "Duplicate CSV Header: {HEADER}",
+ "ERROR_EMPTY_FILE": "The provided file is empty",
+ "ERROR_INVALID_CSV_HEADER":
+ "Invalid CSV Header \"{HEADER}\" is neither an attribute or
parameter",
+ "ERROR_INVALID_GROUP": "No group matching \"{GROUP}\" found",
+ "ERROR_INVALID_FILE_TYPE":
+ "Unsupported file type: \"{TYPE}\"",
+ "ERROR_INVALID_USER_IDENTIFIERS":
+ "Users not found: {IDENTIFIER_LIST}",
+ "ERROR_INVALID_USER_GROUP_IDENTIFIERS":
+ "User Groups not found: {IDENTIFIER_LIST}",
+ "ERROR_NO_FILE_SUPPLIED": "Please select a file to import",
+ "ERROR_AMBIGUOUS_PARENT_GROUP":
+ "Both group and parentIdentifier may be not specified at the same
time",
+ "ERROR_REQUIRED_PROTOCOL":
+ "No connection protocol found in the provided file",
+ "ERROR_REQUIRED_NAME":
+ "No connection name found in the provided file",
+
+ "ERROR_FILE_SINGLE_ONLY": "Please upload only a single file at a time",
+
+ "TABLE_HEADER_NAME" : "Name",
+ "TABLE_HEADER_PROTOCOL" : "Protocol",
+ "TABLE_HEADER_ERRORS" : "Errors",
+ "TABLE_HEADER_ROW_NUMBER": "Row #",
+
+ "UPLOAD_FILE_TYPES": "CSV, JSON, or YAML",
+ "UPLOAD_HELP_LINK": "View Format Tips",
Review Comment:
`ACTION_...`?
##########
guacamole/src/main/frontend/src/translations/en.json:
##########
@@ -905,6 +978,7 @@
"SETTINGS_CONNECTIONS" : {
"ACTION_ACKNOWLEDGE" : "@:APP.ACTION_ACKNOWLEDGE",
+ "ACTION_IMPORT_CONNECTIONS" : "Import",
Review Comment:
This should probably be declared generically as `ACTION_IMPORT` at the `APP`
level, and then referenced here.
##########
guacamole/src/main/frontend/src/translations/en.json:
##########
@@ -183,6 +183,79 @@
},
+ "IMPORT": {
+
+ "ACTION_ACKNOWLEDGE" : "@:APP.ACTION_ACKNOWLEDGE",
+
+ "BUTTON_CANCEL": "Cancel",
+ "BUTTON_CLEAR": "Clear",
+ "BUTTON_IMPORT": "Import Connections",
+
+ "CONNECTIONS_IMPORTED_SUCCESS": "{NUMBER} connections imported
successfully.",
+
+ "DIALOG_HEADER_ERROR" : "@:APP.DIALOG_HEADER_ERROR",
+ "DIALOG_HEADER_SUCCESS": "Success",
+
+ "FIELD_PLACEHOLDER_FILTER" : "@:APP.FIELD_PLACEHOLDER_FILTER",
+
+ "HEADER": "Connection Import",
+
+ "HELP_HEADER": "Connection Import File Format",
+
+ "HELP_FILE_TYPE_HEADER": "File Types",
+ "HELP_FILE_TYPE_DESCRIPTION" : "Three file types are supported for
connection import: CSV, JSON, and YAML. The same data may be specified by each
file type. This must include the connection name and protocol. Optionally, a
connection group location, a list of users and/or user groups to grant access,
connection parameters, or connection protocols may also be specified. Any users
or user groups that do not exist in the current data source will be
automatically created.",
+
+ "HELP_CSV_HEADER": "CSV Format",
+ "HELP_CSV_DESCRIPTION": "A connection import CSV file has one
connection record per row. Each column will specify a connection field. At
minimum the connection name and protocol must be specified.",
+ "HELP_CSV_MORE_DETAILS": "The CSV header for each row specifies the
connection field. The connection group ID that the connection should be
imported into may be directly specified with \"parentIdentifier\", or the path
to the parent group may be specified using \"group\" as shown below. In most
cases, there should be no conflict between fields, but if needed, an \"
(attribute)\" or \" (parameter)\" suffix may be added to disambiguate. Lists of
user or user group identifiers must be semicolon-seperated.¹",
+
+ "HELP_JSON_HEADER": "JSON Format",
+ "HELP_JSON_DESCRIPTION": "A connection import JSON file is a list of
connection objects. At minimum the connection name and protocol must be
specified in each connection object.",
+ "HELP_JSON_MORE_DETAILS": "The connection group ID that the connection
should be imported into may be directly specified with a \"parentIdentifier\"
field, or the path to the parent group may be specified using a \"group\" field
as shown below. An array of user and user group identifiers to grant access to
may be specified per connection.",
+
+ "HELP_YAML_HEADER": "YAML Format",
+ "HELP_YAML_DESCRIPTION": "A connection import YAML file is a list of
connection objects with exactly the same structure as the JSON format.",
+
+ "HELP_SEMICOLON_FOOTNOTE": "If present, semicolons can be escaped with
a backslash, e.g. \"first\\\\;last\"",
+
+ "ERROR_AMBIGUOUS_CSV_HEADER":
+ "Ambiguous CSV Header \"{HEADER}\" could be either a connection
attribute or parameter",
+ "ERROR_ARRAY_REQUIRED":
+ "The provided file must contain a list of connections",
+ "ERROR_DUPLICATE_CSV_HEADER":
+ "Duplicate CSV Header: {HEADER}",
+ "ERROR_EMPTY_FILE": "The provided file is empty",
+ "ERROR_INVALID_CSV_HEADER":
+ "Invalid CSV Header \"{HEADER}\" is neither an attribute or
parameter",
+ "ERROR_INVALID_GROUP": "No group matching \"{GROUP}\" found",
+ "ERROR_INVALID_FILE_TYPE":
+ "Unsupported file type: \"{TYPE}\"",
+ "ERROR_INVALID_USER_IDENTIFIERS":
+ "Users not found: {IDENTIFIER_LIST}",
+ "ERROR_INVALID_USER_GROUP_IDENTIFIERS":
+ "User Groups not found: {IDENTIFIER_LIST}",
+ "ERROR_NO_FILE_SUPPLIED": "Please select a file to import",
+ "ERROR_AMBIGUOUS_PARENT_GROUP":
+ "Both group and parentIdentifier may be not specified at the same
time",
+ "ERROR_REQUIRED_PROTOCOL":
+ "No connection protocol found in the provided file",
+ "ERROR_REQUIRED_NAME":
+ "No connection name found in the provided file",
+
+ "ERROR_FILE_SINGLE_ONLY": "Please upload only a single file at a time",
+
+ "TABLE_HEADER_NAME" : "Name",
+ "TABLE_HEADER_PROTOCOL" : "Protocol",
+ "TABLE_HEADER_ERRORS" : "Errors",
+ "TABLE_HEADER_ROW_NUMBER": "Row #",
+
+ "UPLOAD_FILE_TYPES": "CSV, JSON, or YAML",
+ "UPLOAD_HELP_LINK": "View Format Tips",
+ "UPLOAD_DROP_TITLE": "Drop a File Here",
+ "UPLOAD_BROWSE_LINK": "Browse for File"
Review Comment:
This is probably an `ACTION_`.
##########
guacamole/src/main/frontend/src/translations/en.json:
##########
@@ -183,6 +183,79 @@
},
+ "IMPORT": {
+
+ "ACTION_ACKNOWLEDGE" : "@:APP.ACTION_ACKNOWLEDGE",
+
+ "BUTTON_CANCEL": "Cancel",
+ "BUTTON_CLEAR": "Clear",
+ "BUTTON_IMPORT": "Import Connections",
+
+ "CONNECTIONS_IMPORTED_SUCCESS": "{NUMBER} connections imported
successfully.",
+
+ "DIALOG_HEADER_ERROR" : "@:APP.DIALOG_HEADER_ERROR",
+ "DIALOG_HEADER_SUCCESS": "Success",
+
+ "FIELD_PLACEHOLDER_FILTER" : "@:APP.FIELD_PLACEHOLDER_FILTER",
+
+ "HEADER": "Connection Import",
+
+ "HELP_HEADER": "Connection Import File Format",
+
+ "HELP_FILE_TYPE_HEADER": "File Types",
Review Comment:
`SECTION_HEADER_...`?
##########
guacamole/src/main/frontend/src/translations/en.json:
##########
@@ -183,6 +183,79 @@
},
+ "IMPORT": {
+
+ "ACTION_ACKNOWLEDGE" : "@:APP.ACTION_ACKNOWLEDGE",
+
+ "BUTTON_CANCEL": "Cancel",
+ "BUTTON_CLEAR": "Clear",
+ "BUTTON_IMPORT": "Import Connections",
+
+ "CONNECTIONS_IMPORTED_SUCCESS": "{NUMBER} connections imported
successfully.",
+
+ "DIALOG_HEADER_ERROR" : "@:APP.DIALOG_HEADER_ERROR",
+ "DIALOG_HEADER_SUCCESS": "Success",
+
+ "FIELD_PLACEHOLDER_FILTER" : "@:APP.FIELD_PLACEHOLDER_FILTER",
+
+ "HEADER": "Connection Import",
+
+ "HELP_HEADER": "Connection Import File Format",
+
+ "HELP_FILE_TYPE_HEADER": "File Types",
+ "HELP_FILE_TYPE_DESCRIPTION" : "Three file types are supported for
connection import: CSV, JSON, and YAML. The same data may be specified by each
file type. This must include the connection name and protocol. Optionally, a
connection group location, a list of users and/or user groups to grant access,
connection parameters, or connection protocols may also be specified. Any users
or user groups that do not exist in the current data source will be
automatically created.",
+
+ "HELP_CSV_HEADER": "CSV Format",
+ "HELP_CSV_DESCRIPTION": "A connection import CSV file has one
connection record per row. Each column will specify a connection field. At
minimum the connection name and protocol must be specified.",
+ "HELP_CSV_MORE_DETAILS": "The CSV header for each row specifies the
connection field. The connection group ID that the connection should be
imported into may be directly specified with \"parentIdentifier\", or the path
to the parent group may be specified using \"group\" as shown below. In most
cases, there should be no conflict between fields, but if needed, an \"
(attribute)\" or \" (parameter)\" suffix may be added to disambiguate. Lists of
user or user group identifiers must be semicolon-seperated.¹",
+
+ "HELP_JSON_HEADER": "JSON Format",
+ "HELP_JSON_DESCRIPTION": "A connection import JSON file is a list of
connection objects. At minimum the connection name and protocol must be
specified in each connection object.",
+ "HELP_JSON_MORE_DETAILS": "The connection group ID that the connection
should be imported into may be directly specified with a \"parentIdentifier\"
field, or the path to the parent group may be specified using a \"group\" field
as shown below. An array of user and user group identifiers to grant access to
may be specified per connection.",
+
+ "HELP_YAML_HEADER": "YAML Format",
+ "HELP_YAML_DESCRIPTION": "A connection import YAML file is a list of
connection objects with exactly the same structure as the JSON format.",
+
+ "HELP_SEMICOLON_FOOTNOTE": "If present, semicolons can be escaped with
a backslash, e.g. \"first\\\\;last\"",
+
+ "ERROR_AMBIGUOUS_CSV_HEADER":
+ "Ambiguous CSV Header \"{HEADER}\" could be either a connection
attribute or parameter",
+ "ERROR_ARRAY_REQUIRED":
+ "The provided file must contain a list of connections",
+ "ERROR_DUPLICATE_CSV_HEADER":
+ "Duplicate CSV Header: {HEADER}",
+ "ERROR_EMPTY_FILE": "The provided file is empty",
+ "ERROR_INVALID_CSV_HEADER":
+ "Invalid CSV Header \"{HEADER}\" is neither an attribute or
parameter",
+ "ERROR_INVALID_GROUP": "No group matching \"{GROUP}\" found",
+ "ERROR_INVALID_FILE_TYPE":
+ "Unsupported file type: \"{TYPE}\"",
+ "ERROR_INVALID_USER_IDENTIFIERS":
+ "Users not found: {IDENTIFIER_LIST}",
+ "ERROR_INVALID_USER_GROUP_IDENTIFIERS":
+ "User Groups not found: {IDENTIFIER_LIST}",
+ "ERROR_NO_FILE_SUPPLIED": "Please select a file to import",
+ "ERROR_AMBIGUOUS_PARENT_GROUP":
+ "Both group and parentIdentifier may be not specified at the same
time",
+ "ERROR_REQUIRED_PROTOCOL":
+ "No connection protocol found in the provided file",
+ "ERROR_REQUIRED_NAME":
+ "No connection name found in the provided file",
+
+ "ERROR_FILE_SINGLE_ONLY": "Please upload only a single file at a time",
+
+ "TABLE_HEADER_NAME" : "Name",
+ "TABLE_HEADER_PROTOCOL" : "Protocol",
+ "TABLE_HEADER_ERRORS" : "Errors",
+ "TABLE_HEADER_ROW_NUMBER": "Row #",
+
+ "UPLOAD_FILE_TYPES": "CSV, JSON, or YAML",
Review Comment:
`INFO_...`? Or `HELP_...`?
##########
guacamole/src/main/frontend/src/images/action-icons/guac-monitor-add-many.svg:
##########
Review Comment:
I think it would make more sense for this icon to show multiple monitors
than multiple plus signs.
##########
guacamole/src/main/frontend/src/translations/en.json:
##########
@@ -183,6 +183,79 @@
},
+ "IMPORT": {
+
+ "ACTION_ACKNOWLEDGE" : "@:APP.ACTION_ACKNOWLEDGE",
+
+ "BUTTON_CANCEL": "Cancel",
+ "BUTTON_CLEAR": "Clear",
+ "BUTTON_IMPORT": "Import Connections",
+
+ "CONNECTIONS_IMPORTED_SUCCESS": "{NUMBER} connections imported
successfully.",
+
+ "DIALOG_HEADER_ERROR" : "@:APP.DIALOG_HEADER_ERROR",
+ "DIALOG_HEADER_SUCCESS": "Success",
+
+ "FIELD_PLACEHOLDER_FILTER" : "@:APP.FIELD_PLACEHOLDER_FILTER",
+
+ "HEADER": "Connection Import",
+
+ "HELP_HEADER": "Connection Import File Format",
Review Comment:
Same here - this needs to be more specific to the meaning of the string and
use the established translation key prefixes.
##########
guacamole/src/main/frontend/src/translations/en.json:
##########
@@ -183,6 +183,79 @@
},
+ "IMPORT": {
+
+ "ACTION_ACKNOWLEDGE" : "@:APP.ACTION_ACKNOWLEDGE",
+
+ "BUTTON_CANCEL": "Cancel",
+ "BUTTON_CLEAR": "Clear",
+ "BUTTON_IMPORT": "Import Connections",
+
+ "CONNECTIONS_IMPORTED_SUCCESS": "{NUMBER} connections imported
successfully.",
Review Comment:
This needs a prefix - presumably `INFO_`?
##########
guacamole/src/main/frontend/src/translations/en.json:
##########
@@ -183,6 +183,79 @@
},
+ "IMPORT": {
+
+ "ACTION_ACKNOWLEDGE" : "@:APP.ACTION_ACKNOWLEDGE",
+
+ "BUTTON_CANCEL": "Cancel",
+ "BUTTON_CLEAR": "Clear",
+ "BUTTON_IMPORT": "Import Connections",
+
+ "CONNECTIONS_IMPORTED_SUCCESS": "{NUMBER} connections imported
successfully.",
+
+ "DIALOG_HEADER_ERROR" : "@:APP.DIALOG_HEADER_ERROR",
+ "DIALOG_HEADER_SUCCESS": "Success",
+
+ "FIELD_PLACEHOLDER_FILTER" : "@:APP.FIELD_PLACEHOLDER_FILTER",
+
+ "HEADER": "Connection Import",
Review Comment:
The name of this key needs to be more specific to the meaning of the string,
not just `HEADER`. Assuming this is for a section of a page, the prefix should
also be `SECTION_HEADER_`.
##########
guacamole/src/main/frontend/src/translations/en.json:
##########
@@ -183,6 +183,79 @@
},
+ "IMPORT": {
+
+ "ACTION_ACKNOWLEDGE" : "@:APP.ACTION_ACKNOWLEDGE",
+
+ "BUTTON_CANCEL": "Cancel",
+ "BUTTON_CLEAR": "Clear",
+ "BUTTON_IMPORT": "Import Connections",
+
+ "CONNECTIONS_IMPORTED_SUCCESS": "{NUMBER} connections imported
successfully.",
+
+ "DIALOG_HEADER_ERROR" : "@:APP.DIALOG_HEADER_ERROR",
+ "DIALOG_HEADER_SUCCESS": "Success",
+
+ "FIELD_PLACEHOLDER_FILTER" : "@:APP.FIELD_PLACEHOLDER_FILTER",
+
+ "HEADER": "Connection Import",
+
+ "HELP_HEADER": "Connection Import File Format",
+
+ "HELP_FILE_TYPE_HEADER": "File Types",
+ "HELP_FILE_TYPE_DESCRIPTION" : "Three file types are supported for
connection import: CSV, JSON, and YAML. The same data may be specified by each
file type. This must include the connection name and protocol. Optionally, a
connection group location, a list of users and/or user groups to grant access,
connection parameters, or connection protocols may also be specified. Any users
or user groups that do not exist in the current data source will be
automatically created.",
+
+ "HELP_CSV_HEADER": "CSV Format",
+ "HELP_CSV_DESCRIPTION": "A connection import CSV file has one
connection record per row. Each column will specify a connection field. At
minimum the connection name and protocol must be specified.",
+ "HELP_CSV_MORE_DETAILS": "The CSV header for each row specifies the
connection field. The connection group ID that the connection should be
imported into may be directly specified with \"parentIdentifier\", or the path
to the parent group may be specified using \"group\" as shown below. In most
cases, there should be no conflict between fields, but if needed, an \"
(attribute)\" or \" (parameter)\" suffix may be added to disambiguate. Lists of
user or user group identifiers must be semicolon-seperated.¹",
Review Comment:
Is that `¹` at the end intentional?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
