jmuehlner commented on code in PR #833:
URL: https://github.com/apache/guacamole-client/pull/833#discussion_r1165923874
##########
guacamole/src/main/frontend/src/app/import/services/connectionParseService.js:
##########
@@ -167,7 +196,7 @@ angular.module('import').factory('connectionParseService',
// Set the parent identifier now that it's known
return {
- ...connection,
+ ..._.omit(connection, 'group'),
Review Comment:
This isn't strictly necessary - when passed to the `Connection` constructor
later, this will automatically get removed, and will actually incur a small
performance penalty from copying the connection object.
If people don't think the added cleanliness of removing the `group` field at
this point is worth it, I'd be ok with removing this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
