necouchman commented on code in PR #833:
URL: https://github.com/apache/guacamole-client/pull/833#discussion_r1165939858
##########
guacamole/src/main/frontend/src/app/import/services/connectionParseService.js:
##########
@@ -167,7 +196,7 @@ angular.module('import').factory('connectionParseService',
// Set the parent identifier now that it's known
return {
- ...connection,
+ ..._.omit(connection, 'group'),
Review Comment:
If the performance penalty is negligible and doesn't change depending on the
number of connections you import, then I'm fine leaving it. If the performance
penalty scales as you increase the number of connections, then it seems like
removing this is probably a good idea, particularly if it is going to get taken
off elsewhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
